-
Notifications
You must be signed in to change notification settings - Fork 90
Add default retention policy #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Development
Are you sure you want to change the base?
Conversation
Bionic711
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing needed to stop the PR, but a couple notes to do in a future push.
Updated log_event and dissemination of error directly to front end. Approve when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces admin-configurable organization-wide default retention policies for conversations and documents, allowing administrators to set defaults per workspace type that users can either accept or override. It also includes fixes for sovereign cloud authentication, user search UX improvements, private networking support, and Control Center application roles.
Changes:
- Retention Policy Defaults: Adds organization-level default retention policies with admin force-push capability, new API endpoints, and conditional UI based on enabled workspace types
- Bug Fixes: Fixes sovereign cloud cognitive services scope hardcoding and replaces browser alerts with toast notifications in user search
- Infrastructure: Adds comprehensive private networking support via AZD/Bicep with VNet integration and private endpoints
- Access Control: Introduces two new Control Center application roles for finer-grained permissions
- Dependency Updates: Updates Werkzeug to 3.1.5 and aiohttp to 3.13.3
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| config.py | Version updated to 0.236.011 |
| functions_settings.py | Added 6 new default retention policy settings for each workspace type |
| route_frontend_admin_settings.py | Handles saving of new default retention settings from admin form |
| route_backend_retention_policy.py | Implements GET defaults and POST force-push API endpoints with activity logging |
| functions_retention_policy.py | Adds resolve_retention_value() helper to handle 'default' value resolution |
| functions_activity_logging.py | Implements log_retention_policy_force_push() for audit trail |
| admin_settings.html | Adds default retention UI with conditional visibility and force push modal |
| profile.html | Updates retention dropdowns with "Using organization default" option |
| control_center.html | Adds retention policy settings for group and public workspaces with org defaults |
| workspace-manager.js | Implements public workspace retention settings loading and saving |
| requirements.txt | Updates Werkzeug (3.1.4→3.1.5) and aiohttp (3.12.15→3.13.3) |
| release_notes.md | Documents all new features and bug fixes for v0.236.011 |
| RETENTION_POLICY_DEFAULTS.md | Comprehensive feature documentation with examples and configuration |
| PRIVATE_NETWORKING_SUPPORT.md | Documents private networking deployment via AZD with architecture diagrams |
| CONTROL_CENTER_APPLICATION_ROLES.md | Documents new application roles for Control Center access control |
| USER_AGREEMENT.md | Updates version reference to 0.236.011 |
| USER_SEARCH_TOAST_INLINE_MESSAGES_FIX.md | Documents UX improvement replacing alerts with inline messages |
| SOVEREIGN_CLOUD_COGNITIVE_SERVICES_SCOPE_FIX.md | Documents fix for hardcoded commercial Azure scope |
| RETENTION_POLICY_DOCUMENT_DELETION_FIX.md | Pre-existing fix documentation (not changed in this PR) |
docs/explanation/fixes/v0.236.011/USER_SEARCH_TOAST_INLINE_MESSAGES_FIX.md
Show resolved
Hide resolved
Bionic711
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
activity_logscontainer for audit purposes with admin info, affected scopes, and results summary./api/retention-policy/defaults/<workspace_type>(GET) and/api/admin/retention-policy/force-push(POST) endpoints.functions_settings.py,admin_settings.html,route_frontend_admin_settings.py,route_backend_retention_policy.py,functions_retention_policy.py,functions_activity_logging.py,profile.html,control_center.html,workspace-manager.js.